Conversation
Co-authored-by: Jeff Rasley <jerasley@microsoft.com> Co-authored-by: Shaden Smith <shaden.smith@microsoft.com> Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Samyam Rajbhandari <samyamr@microsoft.com> Co-authored-by: Reza Yazdani <44502768+RezaYazdaniAminabadi@users.noreply.github.com> Co-authored-by: eltonzheng <eltonz@microsoft.com> Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
jeffra
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
Closed
1. GPT2ModelPipe->MockGPT2ModelPipe, due to hacks associated with GPT2ModelPipe name 2. Hardcode attn mask in mock gpt model pipe, newer PP requires stashing attn mask to get around issues with bool dtypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds several changes to master that were only originally in the
big-sciencebranch. The intent is to bring the big science project over to deepspeed master for development and testing and then they can freeze their deepspeed version at a later date.A few significant changes this brings:
(1) pipeline parallelism support for NCCL send/recv
(2) support for newer megatron, e.g., https://github.com/microsoft/megatron-deepspeed
(3) support for querying grad norm from the engine